<html>
<head><meta charset="utf-8"><title>crater latest commit warning · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/crater.20latest.20commit.20warning.html">crater latest commit warning</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="221377362"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/crater%20latest%20commit%20warning/near/221377362" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/crater.20latest.20commit.20warning.html#221377362">(Jan 02 2021 at 00:58)</a>:</h4>
<p>I get a warning about the latest commit not matching the try build here: <a href="https://github.com/rust-lang/rust/pull/80587#issuecomment-753411387">https://github.com/rust-lang/rust/pull/80587#issuecomment-753411387</a><br>
I thought this was to alert the user if there were multiple try builds, and the wrong one was detected, but there's only one try build in this PR. Is this a false positive, or have I made a mistake?</p>



<a name="221377517"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/crater%20latest%20commit%20warning/near/221377517" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/crater.20latest.20commit.20warning.html#221377517">(Jan 02 2021 at 01:03)</a>:</h4>
<p>the same happened to ralf earlier <a href="https://github.com/rust-lang/rust/pull/80579#issuecomment-753370250">https://github.com/rust-lang/rust/pull/80579#issuecomment-753370250</a></p>



<a name="221378647"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/crater%20latest%20commit%20warning/near/221378647" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/crater.20latest.20commit.20warning.html#221378647">(Jan 02 2021 at 01:42)</a>:</h4>
<p>I think that's a bug in my check</p>



<a name="221378651"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/crater%20latest%20commit%20warning/near/221378651" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/crater.20latest.20commit.20warning.html#221378651">(Jan 02 2021 at 01:42)</a>:</h4>
<p>it was working when I tested it locally, but it doesn't see to work when deployed</p>



<a name="221379808"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/crater%20latest%20commit%20warning/near/221379808" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/crater.20latest.20commit.20warning.html#221379808">(Jan 02 2021 at 02:20)</a>:</h4>
<p>Opened <a href="https://github.com/rust-lang/crater/pull/557">https://github.com/rust-lang/crater/pull/557</a></p>



<a name="221379811"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/crater%20latest%20commit%20warning/near/221379811" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/crater.20latest.20commit.20warning.html#221379811">(Jan 02 2021 at 02:20)</a>:</h4>
<p>I had created my fake 'try' commits incorrectly when testing</p>



<a name="221400546"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/crater%20latest%20commit%20warning/near/221400546" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/crater.20latest.20commit.20warning.html#221400546">(Jan 02 2021 at 13:43)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116113">lqd</span> <a href="#narrow/stream/242791-t-infra/topic/crater.20latest.20commit.20warning/near/221377517">said</a>:</p>
<blockquote>
<p>the same happened to ralf earlier <a href="https://github.com/rust-lang/rust/pull/80579#issuecomment-753370250">https://github.com/rust-lang/rust/pull/80579#issuecomment-753370250</a></p>
</blockquote>
<p>oh, it did... I had not even noticed that warning^^</p>



<a name="221403358"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/crater%20latest%20commit%20warning/near/221403358" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/crater.20latest.20commit.20warning.html#221403358">(Jan 02 2021 at 15:04)</a>:</h4>
<p>Once it's fixed, we might want to make it more prominent</p>



<a name="221403373"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/crater%20latest%20commit%20warning/near/221403373" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/crater.20latest.20commit.20warning.html#221403373">(Jan 02 2021 at 15:05)</a>:</h4>
<p>once of my previous macro-hygiene-fix PRs with merged with an unexpectedly large number of regressions, due to an old try build being used on Crter</p>



<a name="221403394"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/crater%20latest%20commit%20warning/near/221403394" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/crater.20latest.20commit.20warning.html#221403394">(Jan 02 2021 at 15:05)</a>:</h4>
<p>which is what prompted me to add the check</p>



<a name="221408238"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/crater%20latest%20commit%20warning/near/221408238" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/crater.20latest.20commit.20warning.html#221408238">(Jan 02 2021 at 17:19)</a>:</h4>
<p>makes sense. (in this case I almost dliberately used an old try build since the changes were only in tests and docs, but then I was like "whatever, try builds are quick"^^)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>